SQLite3 Instrumentation#719
Conversation
cnnradams
force-pushed
the
sqlite3-instrumentation
branch
2 times, most recently
from
11e94e5 to
c906159
Compare
cnnradams
force-pushed
the
sqlite3-instrumentation
branch
from
c906159 to
ece7b41
Compare
|
|
||
| cnx = sqlite3.connect('example.db') | ||
| cursor = cnx.cursor() | ||
| cursor.execute("INSERT INTO test (testField) VALUES (123)" |
| flask,django: pip install {toxinidir}/opentelemetry-auto-instrumentation | ||
| flask: pip install {toxinidir}/ext/opentelemetry-ext-flask[test] | ||
|
|
||
| dbapi: pip install {toxinidir}/opentelemetry-auto-instrumentation |
There was a problem hiding this comment.
Do you need the auto-instrumentation module for this test suite?
lzchen
left a comment
lzchen
left a comment
There was a problem hiding this comment.
LGTM. Some non-blocking comments
hectorhdzg
left a comment
hectorhdzg
left a comment
There was a problem hiding this comment.
LGTM, it would be nice to add docker tests for this integration, maybe creating an issue for it so we don't forget.
@cnnradams if that's the case, can you file a ticket and pick this up as a followup PR? Would love to pay down this debt as we go along. Regarding where to put this code, I'm open to either a more specific shared package (e.g. opentelemetry-instrumentation-dbapi), or a mega-shared package for all shared utils across all instrumentations. @codeboten @c24t for their thoughts. In the meantime I'll merge this PR. Thanks! |
test: fix and add tests closes open-telemetry#642 Signed-off-by: Olivier Albertini <olivier.albertini@montreal.ca>
5 participants
Adds instrumentation for python sqlite3 library.
There is a lot of repeat code in the SQLite3Instrumentor (shared with every other DBAPI instrumentor), it could possibly be pulled out into a DBAPIInstrumentor that can be subclassed in this PR or another.
Resolves #683